fix: json tag formatting for Go#2431
Merged
jonaslagoni merged 2 commits intoasyncapi:masterfrom Feb 8, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
✅ Deploy Preview for modelina canceled.
|
94e65c4 to
330590a
Compare
330590a to
7c4fbd7
Compare
Contributor
Author
I have fixed this with a new commit, so this should not be true any more |
|
Pull Request Test Coverage Report for Build 21798133013Details
💛 - Coveralls |
jonaslagoni
approved these changes
Feb 8, 2026
Member
jonaslagoni
left a comment
There was a problem hiding this comment.
Actually surprised it did not require test update 🤨
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
Adds end quote to Go generator JSON struct tag
Related Issue
#2430
Checklist
npm run lint).npm run test).Additional Notes
I have not added tests or documentation as I am unsure what should be done for such a small change